-
Notifications
You must be signed in to change notification settings - Fork 576
Symbols Approach for Addressables #1038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbols Approach for Addressables #1038
Conversation
Modifed UnComment for Addressables code into a Settings in Build Settings Editor Window
I hope this is kind of easy to preview or split the changes that i am making ? |
Thanks, this is much easier to understand, You won't have to make a separate PR for each and every small feature, just make sure you can easily see what actually changed. I did actually sync the Unity scripts in master with the 6000 branch after your PR. So a PR to master is fine too. I tried this in my own project that already uses addressables, but where I've always manually built them so far. To get it to work I needed to: Remove these comments: #if USING_ADDRESSABLES
// uncomment for addressables
//using UnityEditor.AddressableAssets;
//using UnityEditor.AddressableAssets.Settings;
#endif And I needed to add an
Having this reference (by name, not GUID) in a project without the Addressables package installed makes it show up greyed out. It doesn't cause any errors and installing the Addressables package enables it again. One small issue seems to be that the state of the checkbox isn't always correct. Maybe this state can be directly loaded from the existence of |
Cool I will note these things down. And I will update the full changes this was raised most probably just to verify everything is fine for reviewing. |
- Prefs not Initializing so that the toggle state was not synced - Uncommented Addressables Headers - Added Name References for Addressables to Editor AsmDef
Sorry for the long delay. I'll make sure to get this sorted this week. |
Just did some tests to confirm:
I spotted a small issue when importing in older legacy Unity versions, but i'll look into that myself. |
d60e160
into
juicycleff:experimental/unity_6000
Since you have merged it now, it is working on this git url from now onwards.
|
Modification on - Uncomment for Addressables as a Setting in Build Settings Editor Window
Description
Used Script Symbols, So that it can be toggle on and off with out much effort. It will get all the available targets present and add a symbol when you press apply.
Type of Change